Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCSMB-12: 3D JSON Array Format #30

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

dimaguy
Copy link

@dimaguy dimaguy commented Mar 30, 2024

I had a brain fart today and decided to write this, open for criticism (even if it is to complain that it is overengineered).

I should write an implementation in the form of a PR to print3d if I have the time.

Standards/CCSMB-12.md Outdated Show resolved Hide resolved
Copy link

@znepb znepb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Standards/CCSMB-12.md Outdated Show resolved Hide resolved
Standards/CCSMB-12.md Outdated Show resolved Hide resolved
Standards/CCSMB-12.md Outdated Show resolved Hide resolved
@EmmaKnijn
Copy link
Member

Is there any reason this should be used over the regular 3dj format?

@dimaguy
Copy link
Author

dimaguy commented Mar 30, 2024

Is there any reason this should be used over the regular 3dj format?

Have you read any of my proposal? Reading any bit of it would get you to realize that my format doesn't replace 3dj, it allows for many 3dj models in a single file and also gives instructions to a builder on how to do it

@dimaguy dimaguy requested a review from znepb March 30, 2024 20:04
@EmmaKnijn
Copy link
Member

Is there a reason why you didnt choose to include details like light level and such in the preset? If there's a good reason i can pass this on.

did you read any bit
Yes I did but I am quite stupid

@dimaguy
Copy link
Author

dimaguy commented Mar 30, 2024

Is there a reason why you didnt choose to include details like light level and such in the preset? If there's a good reason i can pass this on.

did you read any bit
Yes I did but I am quite stupid

  1. They arent in the preset.
  2. They are example optional override fields

@dimaguy
Copy link
Author

dimaguy commented Mar 30, 2024

Oh wait I misunderstood you @EmmaKnijn
They arent in the preset, because it is called in each set of bounds and not in the shape itself, you cant separate it at that point

@EmmaKnijn
Copy link
Member

Alright

@dimaguy
Copy link
Author

dimaguy commented Mar 30, 2024

Alright

Dont forget to leave your approval if you dont want any changes

Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start. In addition to the comments made below, consider adding an Introduction/Preface identifying the scope and purpose of the document. Additionally, terms like "reader", "writer", and "printer" should be defined in that section with precise language.

Thank you for submitting this ❤️

Standards/CCSMB-12.md Outdated Show resolved Hide resolved
Standards/CCSMB-12.md Show resolved Hide resolved
Standards/CCSMB-12.md Outdated Show resolved Hide resolved
Standards/CCSMB-12.md Outdated Show resolved Hide resolved
@dimaguy
Copy link
Author

dimaguy commented Apr 12, 2024

I will be taking a couple of days writing the requested changes (I'd be quicker but I got a test tomorrow), but in the meantime I couldn't help but notice that some of the requested changes didn't happen on other CCSMB standards already merged in (I can tell because I tried to be faithful to them as I wrote mine).

Either way they do sound reasonable and agreeable, so I recommend these guidelines be added to CCSMB-1

@tomodachi94
Copy link
Member

I will be taking a couple of days writing the requested changes (I'd be quicker but I got a test tomorrow),

Don't worry about it! The review process is inherently slow to allow ample time for at least three members to thoroughly review it. Good luck with your test! :)

but in the meantime I couldn't help but notice that some of the requested changes didn't happen on other CCSMB standards already merged in (I can tell because I tried to be faithful to them as I wrote mine).

Yes, I'm trying to hold CCSMB standards to... a higher standard. :)

Either way they do sound reasonable and agreeable, so I recommend these guidelines be added to CCSMB-1

I'm currently working on a major rework of CCSMB-1 to include far, far more guidance and some more requirements for standards :) stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants